Internal nits and house keeping #1832
Merged
+271
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the observability/tracing infrastructure by moving classes from com.mongodb.internal.tracing to com.mongodb.internal.observability.micrometer and refactoring related code to improve maintainability and organization.
Key changes:
- Moved tracing-related classes from
internal.tracingtointernal.observability.micrometerpackage - Extracted
MongoNamespace.COMMAND_COLLECTION_NAMEandADMIN_DB_COMMAND_NAMESPACEconstants to a newMongoNamespaceHelperclass - Refactored
MongoDriverInformationfrom a concrete class to an abstract class withConcreteMongoDriverInformationas the implementation
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| driver-core/src/main/com/mongodb/internal/observability/micrometer/* | Package relocation of tracing classes from internal.tracing |
| driver-core/src/main/com/mongodb/observability/micrometer/MicrometerObservabilitySettings.java | Moved from observability package and updated import references |
| driver-core/src/main/com/mongodb/internal/MongoNamespaceHelper.java | New helper class for namespace constants previously in MongoNamespace |
| driver-core/src/main/com/mongodb/MongoNamespace.java | Deprecated COMMAND_COLLECTION_NAME constant and removed internal constants |
| driver-core/src/main/com/mongodb/MongoDriverInformation.java | Refactored to abstract class pattern |
| driver-core/src/main/com/mongodb/internal/connection/ConcreteMongoDriverInformation.java | New concrete implementation extracted from MongoDriverInformation |
| Various test and implementation files | Updated imports to reference new package structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
driver-core/src/main/com/mongodb/observability/micrometer/MicrometerObservabilitySettings.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/observability/micrometer/MicrometerObservabilitySettings.java
Outdated
Show resolved
Hide resolved
…ometerObservabilitySettings.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ometerObservabilitySettings.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.